Migrate ShareActionHandlerModule to a type-safe Nitro module by nabi-ebrahimi · Pull Request #104550 · Expensify/App

nabi-ebrahimi · 2026-10-21T10:14:11Z

Generate one shared-file contract for Swift, Kotlin, and TypeScript. Keep native storage internal and preserve the existing Onyx timestamp format.

Refs: #104432

Explanation of Change

This PR migrates the legacy ShareActionHandler React Native bridge to a type-safe Nitro module within @expensify/nitro-utils.

It replaces callback-based NativeModules communication and platform-specific payload formats with a single generated SharedFile contract implemented in Kotlin for Android and Swift for iOS. processFiles() now returns Promise<SharedFile[]>, eliminating Android JSON parsing and untyped native dictionaries in the Share flow, while safely falling back to an empty array on web.

The native implementations retain existing share behavior for images, videos, PDFs, plain text, and .txt file attachments, while improving validation for missing, unreadable, empty, or malformed shared content. The Share screen now surfaces the existing attachment-error UI for empty results or native-processing rejections, preventing an endless loading skeleton.

Fixed Issues

$ #104530
PROPOSAL:

Linked PRs

https://github.com/Expensify/Mobile-Expensify/pull/14201

Tests

Build and install a fresh native Android or iOS app containing this PR. Do not use an older binary or a JS-only update.
Open Gallery/Photos and share a JPEG or PNG receipt to Expensify.
Verify the Share screen opens and the receipt preview loads with the correct aspect ratio.
Verify the Submit tab is selected for the scannable receipt.
Complete the normal Submit or Share flow and verify the attachment is sent successfully.
Return to Gallery/Photos and share a different receipt.
Verify the new receipt replaces the previous attachment and the Share screen does not crash.
Share plain text to Expensify and verify the text is available in the Share flow.
On Android, share text beginning with / and verify it is handled as text, not as a missing file path.
Share an unsupported file type and verify the existing wrong-file-type error is displayed.

Verify that no errors appear in the JS console

Offline tests

Build and install a fresh native Android or iOS app containing this PR.
Sign in to Expensify, then disable the device’s internet connection.
Share a JPEG or PNG receipt from Gallery/Photos to Expensify.
Verify the Share screen opens and the receipt preview loads while offline.
Verify the Submit tab is selected for a scannable receipt.
Share plain text to Expensify and verify the text is available in the Share flow while offline.
Share an unsupported file type, such as a .zip, and verify the existing wrong-file-type error appears while offline.
Restore the internet connection after testing.

QA Steps

same as test

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

REC-20261022115641.mp4

Android: mWeb Chrome

N/A

iOS: Native

REC-20261022123326.mp4

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

N/A

Generate one shared-file contract for Swift, Kotlin, and TypeScript. Keep native storage internal and preserve the existing Onyx timestamp format. Refs: Expensify#104432

github-actions · 2026-10-21T10:14:25Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2026-10-21T10:19:25Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ShareActionHandlerModule/index.ts	`0.00% <0.00%> (ø)`
src/libs/actions/UserLocation.ts	`86.66% <80.00%> (-5.65%)`	⬇️
src/pages/Share/ShareRootPage.tsx	`87.25% <86.36%> (+87.25%)`	⬆️
... and 10 files with indirect coverage changes

melvin-bot · 2026-10-22T08:18:51Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-22T08:18:55Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	🔄 Running since 2026-10-22T08:18:51.867707Z	`e0ee644`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

github-actions · 2026-10-22T08:23:09Z

+};
+
+interface ShareActionHandler extends HybridObject<{ios: 'swift'; android: 'kotlin'}> {
+    /** Returns an empty array when no share is pending; rejects if pending data cannot be read. */


❌ CONSISTENCY-15 (docs)

This newly added JSDoc comment joins two independent clauses with a semicolon (...when no share is pending; rejects if pending data cannot be read.). Comments should read as plain, natural sentences; a semicolon used to splice two statements together should be split into two separate sentences.

Suggested fix:

/** Returns an empty array when no share is pending. Rejects if pending data cannot be read. */ processFiles(): Promise<SharedFile[]>;

Reviewed at: e0ee644 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

shubham1206agra · 2026-10-23T15:19:47Z

+                return []
+            }
+
+            return try files.map { try self.processFile($0) }


(Shubham's Ai) This rejects the whole batch if any single file fails processFile (empty, unreadable, not a regular file, or non-UTF-8 text_to_read). The old ObjC module skipped bad files and returned the rest. Could we keep that behavior, e.g. compactMap with try? (logging the skipped file), and only reject if no usable file remains?

Thanks, addressed. The iOS handler now processes each shared file independently, logs and skips files that fail processing, and returns any valid files. If every pending file fails, it still rejects so the existing attachment-error UI is displayed.

shubham1206agra · 2026-10-23T15:21:33Z

+                const tempFile = processedFiles.at(0);
+                if (!tempFile) {
                    setErrorTitle(translate('attachmentPicker.attachmentError'));
                    setErrorMessage(translate('attachmentPicker.errorWhileSelectingCorruptedAttachment'));


(Shubham's Ai) An empty result now shows errorWhileSelectingCorruptedAttachment, but nothing is corrupt in this case; there's just no pending share. This path also runs whenever the app returns to the foreground (the AppState listener calls handleProcessFiles again). Is there an existing message that fits "nothing to share" better?

Thanks, addressed. An initial empty result now displays the existing localized “Attachment not found” message instead of the corrupted-attachment copy. Empty results are ignored after a valid attachment has already loaded, preventing an incorrect alert when the app resumes. I also added an explicit local result type for the Share handler callback.

shubham1206agra · 2026-10-23T15:21:33Z

+            return@parallel arrayOf(SharedFile("text", content, "txt", timestamp, null))
+        }
+
+        if (!file.isFile || !file.canRead() || file.length() == 0L) {


(Shubham's Ai) Throwing on a zero-byte file (here and the size > 0 guard in the Swift implementation) means the user gets the generic attachment error instead of the existing "attachment too small" (sizeNotMet) message from ShareRootPage. Could we let empty files through and keep the JS size validation as the single source of that error?

Thanks, addressed. Zero-byte regular files now reach the existing JavaScript size validation, restoring the sizeNotMet error for applicable file types. Native code continues to reject missing, unreadable, and non-regular files.

shubham1206agra · 2026-10-23T15:21:33Z

+                }
+
+                const {fileExtension} = splitExtensionFromFileName(tempFile?.content);
+                if (tempFile) {


(Shubham's Ai) Nit: after the if (!tempFile) return guard above, this if (tempFile) is always true and the tempFile?. optional chains in this block are redundant. This could be flattened.

Thanks, addressed. The missing-file guard already returns before this block, so I removed the redundant if (tempFile) check and optional chaining, and flattened the remaining shared-file processing without changing behavior.

shubham1206agra · 2026-10-23T15:21:33Z

+    const handleProcessFiles = () => {
+        ShareActionHandler.processFiles()
+            .then((processedFiles) => {
+                if (errorTitle) {


(Shubham's Ai) errorTitle here is the value from the render that started the call, not the current one, so it is stale by the time the promise resolves. This existed before, but the async chain widens the gap. Consider a ref or at least a comment.

Thanks, addressed. Shared-file processing now reads the current error state from a ref rather than the render-time closure. All Share errors go through a helper that updates the ref immediately, preventing a later async result from overwriting or duplicating an existing error.

shubham1206agra · 2026-10-23T15:21:33Z

+
+    override fun processFiles(): Promise<Array<SharedFile>> = Promise.parallel {
+        val context = NitroModules.applicationContext ?: throw IOException("React Native context is unavailable")
+        val preferences = context.getSharedPreferences("shareActionHandler", Context.MODE_PRIVATE)


(Shubham's Ai) Nit: "shareActionHandler" / "shareObject" duplicate IntentHandlerConstants (in both App and Mobile-Expensify), which this module can't import. Could you add a comment pointing at the source so the two don't drift?

Thanks, addressed. I added a comment identifying IntentHandlerConstants as the source of truth for the duplicated preference file and key, and explaining that the standalone Nitro module cannot import app-level Android code.

shubham1206agra · 2026-10-23T15:21:33Z

+                    retriever.release()
+                }
+            }
+            else -> null


(Shubham's Ai) aspectRatio is now undefined for non-media files on both platforms (previously 0 on Android, 1 on iOS). AttachmentPreview treats it as optional, so this looks fine, but please confirm a PDF share still previews correctly.

Thanks for flagging. Confirmed by the existing preview implementation: when aspectRatio is undefined, AttachmentPreview defaults it to 1, and the PDF-specific preview branch also explicitly uses aspectRatio: 1. Therefore, PDF preview behavior is unaffected.

shubham1206agra · 2026-10-23T15:21:33Z

+    NitroModules: {createHybridObject: jest.fn(() => ({processFiles: jest.fn()}))},
+}));
+
+describe('ShareActionHandler native adapter', () => {


(Shubham's Ai) These tests stub processFiles and then assert that it returns the stubbed value, so they only exercise the mock. tests/ui/ShareRootPageTest.tsx covers the real behavior; I think this file can be dropped.

Thanks, agreed. I removed the test because it only asserted values returned from a mocked processFiles() implementation. The ShareRootPage tests continue to cover handling of successful, empty, and rejected shared-file results.

shubham1206agra · 2026-10-23T15:21:33Z

+        let content = isText ? try String(contentsOf: url, encoding: .utf8) : url.absoluteString
+        var aspectRatio: Double?
+
+        if mimeType.hasPrefix("image/"), let image = UIImage(contentsOfFile: url.path), image.size.height > 0 {


(Shubham's Ai) Optional: UIImage(contentsOfFile:) decodes the whole image just to read its dimensions. CGImageSourceCopyPropertiesAtIndex reads only the header, which is cheaper for large photos. (The old ObjC code did the same, so not a regression.)

Thanks for the suggestion. This preserves the existing Objective-C behavior and runs off the UI thread inside Promise.async, so I’ll keep the current implementation in this migration PR. Using CGImageSourceCopyPropertiesAtIndex would be a worthwhile separate performance improvement for large images.

shubham1206agra · 2026-10-23T15:35:47Z

@nabi-ebrahimi Link https://github.com/Expensify/Mobile-Expensify/pull/14201 for HybridApp changes so we can make a build that works.

shubham1206agra · 2026-10-26T15:45:06Z

@nabi-ebrahimi Bump here

nabi-ebrahimi · 2026-10-28T04:41:22Z

@shubham1206agra, I’ve addressed all your feedback. Please take another look when you have a chance. Thanks!

shubham1206agra · 2026-10-28T17:05:28Z

@nabi-ebrahimi You have not completed #104550 (comment). Please do this step first

nabi-ebrahimi · 2026-10-29T05:46:34Z

@nabi-ebrahimi Link https://github.com/Expensify/Mobile-Expensify/pull/14201 for HybridApp changes so we can make a build that works.

@shubham1206agra, Thank you for pointing this out. However, I don't have access to the link you shared. Could you please let me know what I should do? I'd really appreciate your guidance.

shubham1206agra · 2026-10-29T06:21:44Z

@nabi-ebrahimi Link Expensify/Mobile-Expensify#14201 for HybridApp changes so we can make a build that works.

@shubham1206agra, Thank you for pointing this out. However, I don't have access to the link you shared. Could you please let me know what I should do? I'd really appreciate your guidance.

@nabi-ebrahimi Add this PR link to the description of this PR. It does not require any special access

JmillsExpensify

No product review required.

github-actions · 2026-11-02T16:40:30Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-11-02T17:42:10Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-11-02T17:56:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104550 with Mobile-Expensify PR Expensify/Mobile-Expensify#14201.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-451264a1-a1def7e22e-24c9d2bbf06596a4e0ef9a3f0b1428d553584499/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-451264a1-a1def7e22e-095754d6bd92eab1fe79f42981950735467af920/index.html

Web 🕸️
https://104550.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

nabi-ebrahimi · 2026-11-09T07:53:34Z

@nabi-ebrahimi Link https://github.com/Expensify/Mobile-Expensify/pull/14201 for HybridApp changes so we can make a build that works.

@shubham1206agra,

Done! I have updated the PR description and linked the companion PR (https://github.com/Expensify/Mobile-Expensify/pull/14201) under ### Linked PRs as requested.

Also, I’ve merged the latest main branch and resolved all conflicts. Please take a look whenever you have time. Thank you!

nabi-ebrahimi · 2026-11-12T04:59:30Z

@shubham1206agra, Gentle bump. thanks.

refactor(share): migrate native bridge to Nitro

e0ee644

Generate one shared-file contract for Swift, Kotlin, and TypeScript. Keep native storage internal and preserve the existing Onyx timestamp format. Refs: Expensify#104432

melvin-bot Bot requested review from JmillsExpensify and shubham1206agra and removed request for a team October 22, 2026 08:18

melvin-bot Bot removed the request for review from a team October 22, 2026 08:18

github-actions Bot reviewed Oct 22, 2026

View reviewed changes

style(share): split ShareActionHandler JSDoc sentences

94c9c9f

shubham1206agra reviewed Oct 23, 2026

View reviewed changes

Nabi Ebrahimi added 9 commits October 27, 2026 14:25

fix(share): skip invalid iOS shared files

4a89501

fix(share): handle missing shared attachments

a61f525

fix(share): preserve empty-file size validation

8c3dfde

refactor(share): simplify shared-file processing

b9bec89

fix(share): prevent stale shared-file errors

b0eb75a

docs(share): document Android share preference keys

9f7d4c3

test(share): remove redundant handler adapter test

e6323d5

Merge branch 'main' into feat/migrate-share-action-handler-to-nitro

57c6946

Merge branch 'main' into feat/migrate-share-action-handler-to-nitro

451264a

JmillsExpensify reviewed Nov 2, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

Nabi Ebrahimi added 3 commits November 5, 2026 09:14

Merge branch 'main' into feat/migrate-share-action-handler-to-nitro

151c55b

Merge branch 'main' into feat/migrate-share-action-handler-to-nitro

3bf807a

fix(tests): update share location mock for Nitro handler

275badc

Nabi Ebrahimi added 2 commits November 11, 2026 12:02

Merge branch 'main' into feat/migrate-share-action-handler-to-nitro

77abb5c

fix/test fail fix

bd9681d

Conversation

nabi-ebrahimi commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Linked PRs

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

codecov Bot commented Oct 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 22, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 22, 2026

Codex Review Summary

Uh oh!

github-actions Bot Oct 22, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-15 (docs)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Oct 23, 2026

Uh oh!

shubham1206agra commented Oct 26, 2026

Uh oh!

nabi-ebrahimi commented Oct 28, 2026

Uh oh!

shubham1206agra commented Oct 28, 2026

Uh oh!

nabi-ebrahimi commented Oct 29, 2026

Uh oh!

shubham1206agra commented Oct 29, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

nabi-ebrahimi commented Oct 21, 2026 •

edited

Loading

codecov Bot commented Oct 21, 2026 •

edited by github-actions Bot

Loading